Fix behaviour of quantileDeterministic function #25313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse
added
the
pr-bugfix
| setSkipDegree(skip_degree + 1); | ||
|
|
||
| /// Still good? |
There was a problem hiding this comment.
This is the fix.
In previous version, the value is not being filtered after coarsening, so one excessive value can appear in the final reservoir.
| @@ -59,9 +59,10 @@ template <typename T, | |||
| ReservoirSamplerDeterministicOnEmpty OnEmpty = ReservoirSamplerDeterministicOnEmpty::THROW> | |||
| class ReservoirSamplerDeterministic | |||
| { | |||
| bool good(const UInt32 hash) | |||
| private: | |||
There was a problem hiding this comment.
This is old code (circa 2014), it also contains hairy decisions and mistakes. E.g. total_values is calculated and serialized but not used.
This is fine. |
This was referenced Jun 16, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Jun 17, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Jun 17, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Jun 17, 2021
alexey-milovidov
added a commit
that referenced
this pull request
Jun 17, 2021
Backport #25313 to 21.6: Fix behaviour of quantileDeterministic function
alexey-milovidov
added a commit
that referenced
this pull request
Jun 17, 2021
Backport #25313 to 21.3: Fix behaviour of quantileDeterministic function
alexey-milovidov
added a commit
that referenced
this pull request
Jun 17, 2021
Backport #25313 to 21.5: Fix behaviour of quantileDeterministic function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix the possibility of non-deterministic behaviour of the
quantileDeterministicfunction and similar. This closes #20480.