Merging #23843 #25394
Merged
Merging #23843 #25394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse
added
doc-alert
pr-feature
kitaisreal
changed the title
Avogar
reviewed
Jun 17, 2021
| auto & vec_from = col_from->getData(); | ||
| size_t size = vec_from.size(); | ||
| result_array_offsets_data.resize(size); | ||
| result_array_values_data.reserve(size * 2); |
There was a problem hiding this comment.
Seems like heuristic from original author, make sense to reserve additional size for positions before push back. There is no optimal solution probably. It will be most efficient if number has 2 bits set to 1.
Avogar
reviewed
Jun 17, 2021
src/Functions/FunctionsCoding.h
Outdated
| || (result_column = executeType<Int8>(in_column)) | ||
| || (result_column = executeType<Int16>(in_column)) | ||
| || (result_column = executeType<Int32>(in_column)) | ||
| || (result_column = executeType<Int64>(in_column)))) |
src/Functions/FunctionsCoding.h
Outdated
|
|
||
| DataTypePtr getReturnTypeImpl(const DataTypes & arguments) const override | ||
| { | ||
| if (!isNativeInteger(arguments[0])) |
There was a problem hiding this comment.
Not native may be also ok?
There was a problem hiding this comment.
We can also extend bitmask functions for 128, 256 bits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Original pull request #23843.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Added function
bitPositionsToArray. Closes #23792. Author [Kevin Wan] (@MaxWk).