Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coredump in creating distributed table #28686

Merged
merged 1 commit into from
Sep 8, 2021

Conversation

ljcui
Copy link

@ljcui ljcui commented Sep 7, 2021

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Bug Fix (user-visible misbehaviour in official stable or prestable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix the coredump in the creation of distributed tables, when the parameters passed in are wrong

Detailed description / Documentation draft:

sql like this:
create table td1 engine = Distributed(test_shard_localhost, currentDatabase(), 't', xxHash32(val), default) as t;
If the fifth parameter default is not wrapped in quotation marks, a coredump will be generated.

It's okay to write like this:
create table td1 engine = Distributed(cluster_2shards_2replicas, currentDatabase(), 't', xxHash32(val), 'default') as t;

@robot-clickhouse robot-clickhouse added the pr-bugfix Pull request with bugfix, not backported by default label Sep 7, 2021
@vdimir vdimir self-assigned this Sep 7, 2021
Copy link
Member

@vdimir vdimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

@vdimir vdimir merged commit 70fbc85 into ClickHouse:master Sep 8, 2021
alexey-milovidov added a commit that referenced this pull request Sep 8, 2021
Backport #28686 to 21.9: Fix coredump in creating distributed table
alexey-milovidov added a commit that referenced this pull request Sep 11, 2021
Backport #28686 to 21.10: Fix coredump in creating distributed table
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix Pull request with bugfix, not backported by default
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants