Fix possible odbc invalid cursor state #29518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse
added
the
pr-bugfix
Avogar
approved these changes
Sep 29, 2021
tavplubix
approved these changes
Sep 29, 2021
| /// Invalid cursor state is a retriable error. | ||
| /// Invalid transaction state 25000. Truncate to 4 letters, because nanodbc does it. | ||
| /// https://docs.microsoft.com/ru-ru/sql/odbc/reference/appendixes/appendix-a-odbc-error-codes?view=sql-server-ver15 | ||
| if (e.state().starts_with("08") || e.state().starts_with("24") || e.state().starts_with("2500")) |
There was a problem hiding this comment.
Suggested change
| if (e.state().starts_with("08") || e.state().starts_with("24") || e.state().starts_with("2500")) | |
| if (e.state().starts_with("08") || e.state().starts_with("24") || e.state().starts_with("25")) |
See https://www.postgresql.org/docs/10/errcodes-appendix.html
|
@Mergifyio update |
|
Command
|
This was referenced Sep 30, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Sep 30, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Sep 30, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Sep 30, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Sep 30, 2021
kssenii
added a commit
that referenced
this pull request
Oct 1, 2021
Backport #29518 to 21.9: Fix possible odbc invalid cursor state
kssenii
added a commit
that referenced
this pull request
Oct 1, 2021
Backport #29518 to 21.8: Fix possible odbc invalid cursor state
kssenii
added a commit
that referenced
this pull request
Oct 1, 2021
Backport #29518 to 21.10: Fix possible odbc invalid cursor state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
In ODBC bridge add retries for error Invalid cursor state. It is a retriable error. Closes #29473.