Better clickhouse-client multiline input #31123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse
added
the
pr-improvement
amosbird
force-pushed
the
repl-improvement
branch
3 times, most recently
from
28b26c2
to
25e7db4
Compare
|
“Timeout dropping database test_3gkcv6 after test”? but why |
novikd
reviewed
Nov 9, 2021
| @@ -11,7 +11,7 @@ ${CLICKHOUSE_CLIENT} -q "SELECT 'CREATE TABLE test_' || hex(randomPrintableASCII | |||
| function stress() | |||
| { | |||
| while true; do | |||
| "${CURDIR}"/01526_client_start_and_exit.expect-not-a-test-case | grep -v -P 'ClickHouse client|Connecting|Connected|:\) Bye\.|new year|^\s*$|spawn bash|^0\s*$' | |||
| "${CURDIR}"/01526_client_start_and_exit.expect-not-a-test-case | grep -v -P 'ClickHouse client|Connecting|Connected|:\) Bye\.|new year|^\s*$|spawn bash|\?2004l|^0\s*$' | |||
There was a problem hiding this comment.
I didn't understand why this change checks correctness. Could you please explain it?
There was a problem hiding this comment.
It's most likely because parallel running expect emulated terminal doesn't work well with bracketed paste enabling sequence, which is \e033?2004l (FYI https://cirw.in/blog/bracketed-paste)
There was a problem hiding this comment.
Then write a comment inside the test, otherwise it's very obscure.
amosbird
force-pushed
the
repl-improvement
branch
from
25e7db4
to
9329473
Compare
alexey-milovidov
approved these changes
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Enable multiline editing in clickhouse-client by default. This addresses #31121 .
Before #30143 , we didn't support native multline editing in clickhouse-client. Thus bracketed pasting is only enabled when
-nis enabled and-mis disabled (see #7757) . Now we allow multiple sections of multiline inputs delimited by extender character:\.Detailed description / Documentation draft:
.