use LowCardinality for _file and _path virtual columns in StorageFile #34317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse
added
the
pr-not-for-changelog
robot-clickhouse
added
pr-performance
alexey-milovidov
approved these changes
Feb 4, 2022
|
Ok. There are no new tests. But performance tests will be difficult to construct. |
|
@ucasfl I forgot to say that we have other similar cases - s3, hdfs, etc. Grep by |
OK, I will do it. |
ucasfl
added a commit
to ucasfl/ClickHouse
that referenced
this pull request
Feb 5, 2022
alexey-milovidov
added a commit
that referenced
this pull request
Feb 6, 2022
use LowCardinality type for _file and _path in some Storages, continue of #34317
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
_fileand_pathvirtual columns (in file-like table engines) are madeLowCardinality- it will make queries for multiple files faster. Closes #34300