New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to skip not found urls for globs #34392

Merged

kssenii merged 6 commits into ClickHouse:master from kssenii:http-buffer-skip-not-found-url-for-globs

Feb 9, 2022

Member

kssenii commented Feb 7, 2022 •

edited by Avogar

Loading

Changelog category (leave one):

Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Allow to skip not found urls for globs when using URL storage / table function.
Also closes #34359

Fix

eba3011

robot-clickhouse added the pr-improvement label

Avogar self-assigned this

Avogar reviewed

View reviewed changes

src/Storages/StorageURL.cpp Outdated Show resolved Hide resolved

Avogar reviewed

View reviewed changes

src/Storages/StorageURL.cpp Outdated Show resolved Hide resolved

Avogar reviewed

View reviewed changes

src/IO/ReadWriteBufferFromHTTP.h Outdated Show resolved Hide resolved

Avogar reviewed

View reviewed changes

src/IO/ReadWriteBufferFromHTTP.h Outdated Show resolved Hide resolved

Avogar reviewed

View reviewed changes

src/IO/ReadWriteBufferFromHTTP.h Show resolved Hide resolved

kssenii force-pushed the http-buffer-skip-not-found-url-for-globs branch from c93f78f to 9bff5fa Compare

February 8, 2022 10:10


          Fixes

3834bdb

kssenii force-pushed the http-buffer-skip-not-found-url-for-globs branch from 9bff5fa to 3834bdb Compare

February 8, 2022 10:11

Avogar reviewed

View reviewed changes

src/IO/ReadWriteBufferFromHTTP.h Show resolved Hide resolved

Avogar reviewed

View reviewed changes

src/IO/ReadWriteBufferFromHTTP.h Outdated Show resolved Hide resolved

Fix

dc5f035

kssenii force-pushed the http-buffer-skip-not-found-url-for-globs branch from dbbbd8e to dc5f035 Compare

February 8, 2022 12:28


          Merge branch 'master' into http-buffer-skip-not-found-url-for-globs

720310f

Avogar approved these changes

View reviewed changes

Avogar and others added 2 commits

February 8, 2022 17:31


          Fix build

cae1517


          Fix style check

e8a8f46

Member Author

kssenii commented Feb 9, 2022

Integration tests (asan, actions) [2/3] — fail: 29

test_dictionaries_all_layouts_separate_sources
test_storage_s3

Integration tests (asan, actions) [3/3] — fail: 8

test_dictionaries_all_layouts_separate_sources

Integration tests (release, actions) [1/2] — fail: 8

test_dictionaries_all_layouts_separate_sources  and

remaining are also test_dictionaries_all_layouts_separate_sources  

ClickHouse special build check (actions) — 6/7 builds are OK

broker in master

kssenii merged commit 86956ca into ClickHouse:master

Avogar mentioned this pull request

Fix bug in URL engine #34448

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels