-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add InitialQuery event #58195
Add InitialQuery event #58195
Conversation
@@ -264,7 +267,7 @@ String DatabaseReplicatedDDLWorker::tryEnqueueAndExecuteEntry(DDLLogEntry & entr | |||
chassert(!task->entry.query.empty()); | |||
assert(!zookeeper->exists(task->getFinishedNodePath())); | |||
task->is_initial_query = true; | |||
|
|||
ProfileEvents::increment(ProfileEvents::InitialQuery); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not the only place where it is set.
Better, check executeQuery.cpp
Signed-off-by: una <[email protected]>
Signed-off-by: una <[email protected]>
This is an automated comment for commit 2c15135 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
Signed-off-by: una <[email protected]>
@Unalian, the test script has no executable permission. |
Signed-off-by: una <[email protected]>
Sorry for that. I have fixed it. |
@alexey-milovidov Hi, could you please tell me what happened to the PR? It seems like there is something wrong because it shows "Some checks were not successful" but I can not find the problem description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code LGTM.
Changelog category:
Changelog entry:
Add improvement to count InitialQuery
Documentation entry for user-facing changes:
Motivation: Add InitialQuery event. Similar to counting Queries, but only counting initial queries. Event Contains information about the number of events that have occurred in the system. For example, in the table, you can find how many initial queries were processed since the ClickHouse server started.
Example use: