Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add InitialQuery event #58195

Merged
merged 10 commits into from
Feb 13, 2024
Merged

Add InitialQuery event #58195

merged 10 commits into from
Feb 13, 2024

Conversation

Unalian
Copy link
Contributor

@Unalian Unalian commented Dec 23, 2023

Changelog category:

  • Improvement

Changelog entry:

Add improvement to count InitialQuery

Documentation entry for user-facing changes:

  • Motivation: Add InitialQuery event. Similar to counting Queries, but only counting initial queries. Event Contains information about the number of events that have occurred in the system. For example, in the table, you can find how many initial queries were processed since the ClickHouse server started.

  • Example use:

SELECT * FROM system.events where event = 'InitialQuery'

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@CLAassistant
Copy link

CLAassistant commented Dec 23, 2023

CLA assistant check
All committers have signed the CLA.

@Unalian Unalian marked this pull request as draft December 23, 2023 11:54
@@ -264,7 +267,7 @@ String DatabaseReplicatedDDLWorker::tryEnqueueAndExecuteEntry(DDLLogEntry & entr
chassert(!task->entry.query.empty());
assert(!zookeeper->exists(task->getFinishedNodePath()));
task->is_initial_query = true;

ProfileEvents::increment(ProfileEvents::InitialQuery);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not the only place where it is set.
Better, check executeQuery.cpp

@Unalian Unalian marked this pull request as ready for review December 27, 2023 10:10
@amosbird amosbird added the can be tested Allows running workflows for external contributors label Dec 27, 2023
@robot-ch-test-poll robot-ch-test-poll added the pr-feature Pull request with new product feature label Dec 27, 2023
@robot-ch-test-poll
Copy link
Contributor

robot-ch-test-poll commented Dec 27, 2023

This is an automated comment for commit 2c15135 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Check nameDescriptionStatus
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts❌ failure

Signed-off-by: una <[email protected]>
@Unalian Unalian changed the title feat:add InitialQuery event Improvement :add InitialQuery event Dec 27, 2023
@alexey-milovidov
Copy link
Member

@Unalian, the test script has no executable permission.

@Unalian
Copy link
Contributor Author

Unalian commented Dec 27, 2023

@Unalian, the test script has no executable permission.

Sorry for that. I have fixed it.

@robot-ch-test-poll3 robot-ch-test-poll3 added pr-improvement Pull request with some product improvements and removed pr-feature Pull request with new product feature labels Dec 27, 2023
@Unalian
Copy link
Contributor Author

Unalian commented Dec 28, 2023

@alexey-milovidov Hi, could you please tell me what happened to the PR? It seems like there is something wrong because it shows "Some checks were not successful" but I can not find the problem description.

@alexey-milovidov alexey-milovidov changed the title Improvement :add InitialQuery event Add InitialQuery event Dec 28, 2023
Copy link
Member

@alexey-milovidov alexey-milovidov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code LGTM.

@alexey-milovidov alexey-milovidov self-assigned this Feb 13, 2024
@alexey-milovidov alexey-milovidov merged commit b9d3ae3 into ClickHouse:master Feb 13, 2024
259 of 265 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can be tested Allows running workflows for external contributors pr-improvement Pull request with some product improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants