Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add driver.CollectRows and driver.AppendRows #1266

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

EpicStep
Copy link
Contributor

@EpicStep EpicStep commented Apr 5, 2024

These auxiliary functions help with rows processing, examples of use can be seen in the tests

@jkaflik jkaflik self-assigned this Apr 10, 2024
@EpicStep
Copy link
Contributor Author

EpicStep commented May 5, 2024

Hi @jkaflik. I think auxiliary functions that I published in this PR are inappropriate inside the database driver and it's better to put them in a separate repository, what do you think?

@EpicStep EpicStep marked this pull request as draft May 5, 2024 11:40
Copy link
Contributor

@jkaflik jkaflik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather defer it to a separate repository. If we want to keep this as a part of this, we need to consider it as a util subpackage.

@jkaflik jkaflik added the stale requires a follow-up label Jul 1, 2024
@EpicStep
Copy link
Contributor Author

Okey, sounds good, I will check this PR after vacation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale requires a follow-up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants