Append query options to context instead of overwriting. #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jkaflik
approved these changes
Dec 22, 2022
jkaflik
reviewed
Dec 22, 2022
|
@aaron276h thanks! it will be included in upcoming v2.5 release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously every time
clickhouse.Context(context.Context, QueryOption)is called multiple times on the same context object, only the query options in the last call would used. For example:would not persist the the query id.
This PR changes the
clickhouse.Context()logic to first attempt to load the existingQueryOptionswhen called so that query options append instead of overwrite existing ones.It is possible that this is a breaking change for users that have become dependent on this behavior, however it is unlikely that someone is purposefully depending on it today.