Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[client-v2] Query API #1580

Merged
merged 6 commits into from
Apr 9, 2024
Merged

[client-v2] Query API #1580

merged 6 commits into from
Apr 9, 2024

Conversation

chernser
Copy link
Contributor

@chernser chernser commented Apr 2, 2024 •
edited
Loading

Summary

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

mzitnik
mzitnik reviewed Apr 2, 2024
View reviewed changes
client-v2/src/test/java/com/clickhouse/client/query/QueryTests.java Outdated Show resolved Hide resolved
client-v2/src/test/java/com/clickhouse/client/query/QueryTests.java Outdated Show resolved Hide resolved
client-v2/src/main/java/com/clickhouse/client/api/query/QueryResponse.java Outdated
*
*
*/
public class QueryResponse<TOutDataFormat extends DataFormat> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add statistics methods here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be implemented as separate issue #1601

client-v2/src/main/java/com/clickhouse/client/api/query/QueryResponse.java Outdated Show resolved Hide resolved
@chernser chernser changed the title added draft of the query API [client-v2] Query API Apr 5, 2024
@chernser chernser marked this pull request as ready for review April 9, 2024 17:32
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
50.4% Coverage on New Code (required ≥ 80%)
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@chernser chernser merged commit 9a2359c into main Apr 9, 2024
56 of 59 checks passed
@chernser chernser deleted the draft_query_api branch April 9, 2024 18:21
@chernser chernser mentioned this pull request May 13, 2024
Closed
3 tasks
@chernser chernser linked an issue May 13, 2024 that may be closed by this pull request
[client-v2] Method for Getting Metadata #1598
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzitnik mzitnik mzitnik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[client-v2] Method for Getting Metadata
3 participants
@chernser @CLAassistant @mzitnik