Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a test to check, and implementing the fix #1790

Merged
merged 3 commits into from
Aug 26, 2024
Merged

Conversation

Paultagoras
Copy link
Contributor

@Paultagoras Paultagoras commented Aug 26, 2024

Summary

Turns out we were handling BigInteger in BigEndian format rather than LE - the test needed to be adjusted slightly to trigger the error properly.

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

@Paultagoras Paultagoras self-assigned this Aug 26, 2024
@Paultagoras Paultagoras added this to the 0.6.5 milestone Aug 26, 2024
@Paultagoras Paultagoras linked an issue Aug 26, 2024 that may be closed by this pull request
@Paultagoras Paultagoras merged commit d1c90cd into main Aug 26, 2024
56 of 59 checks passed
@Paultagoras Paultagoras deleted the fixing-endian branch August 26, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Count isn't matching expected value
2 participants