Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jdbc] Make ResultSet to return JDBC compliant types for Date/DateTime columns #1886

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

chernser
Copy link
Contributor

@chernser chernser commented Oct 25, 2024

Summary

JDBC defines what data types should be returned by default when ResultSet#getObject() is called. Today returned types do not match this schema and it breaks many external integrations.
This PR add conversion in JDBC driver to resolve the issue. It is important to not change java client itself, because it should operate as is and because it may break interfaces.

Closes: #1409

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot use ResultSet.getObject to retrieve java.sql.Date (JDBC specification violation?)
1 participant