Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move images to clickhouse/ repo #116

Merged
merged 2 commits into from
Sep 9, 2021
Merged

Move images to clickhouse/ repo #116

merged 2 commits into from
Sep 9, 2021

Conversation

alesapin
Copy link
Member

@alesapin alesapin commented Sep 9, 2021

Hi @zhicwu, we are trying to migrate our docker images from yandex/ repo to clickhouse/ repo: ClickHouse/ClickHouse#28656. I'm not sure how to do it for yandex/clickhouse-jdbc-bridge, probably my changes will break someones workflows. Maybe we can push jdbc-bridge to both yandex/clickhouse-jdbc-bridge and clickhouse/jdbc-bridge?

@alesapin alesapin requested a review from zhicwu September 9, 2021 07:37
@zhicwu
Copy link
Contributor

zhicwu commented Sep 9, 2021

That's great. Does this also mean yandex/clickhouse-server will be changed to clickhouse/server? I believe there are integration tests need to be updated as well.

I think we can leave yandex/clickhouse-jdbc-bridge as is and only push new image to clickhouse/jdbc-bridge. As I recalled, we use a robot account for pushing image to docker hub, so as long as the account has access we should be able to do that.

Copy link
Contributor

@zhicwu zhicwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@alesapin
Copy link
Member Author

alesapin commented Sep 9, 2021

That's great. Does this also mean yandex/clickhouse-server will be changed to clickhouse/server? I believe there are integration tests need to be updated as well.

I think we can leave yandex/clickhouse-jdbc-bridge as is and only push new image to clickhouse/jdbc-bridge. As I recalled, we use a robot account for pushing image to docker hub, so as long as the account has access we should be able to do that.

For a long time we will push both yandex/clickhouse-server and clickhouse/clickhouse-server. Robot has access to all repos, so I'll just add another push.

@zhicwu zhicwu changed the base branch from master to develop September 9, 2021 11:06
@zhicwu zhicwu changed the base branch from develop to master September 9, 2021 11:07
@zhicwu zhicwu merged commit 70e1f25 into master Sep 9, 2021
@zhicwu zhicwu deleted the move_to_clickhouse_repo branch September 9, 2021 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants