Infer ResultSet type hints based on DataFormat #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
slvrtrn
commented
Mar 12, 2024
mshustov
reviewed
Mar 19, 2024
| export class ResultSet implements BaseResultSet<Stream.Readable> { | ||
| /** {@link Stream.Readable} with additional types for the `on(data)` method. | ||
| * Everything else is an exact copy from stream.d.ts */ | ||
| export type StreamReadable<T> = Omit<Stream.Readable, 'on'> & { |
There was a problem hiding this comment.
Why do we need the custom definition?
There was a problem hiding this comment.
additional types for the
on(data)method.
By default, it's any there.
mshustov
reviewed
Mar 19, 2024
mshustov
approved these changes
Mar 19, 2024
mshustov
approved these changes
Mar 26, 2024
slvrtrn
added a commit
that referenced
this pull request
Mar 29, 2024
1.0.0 * Add support for URL parameters parsing (#232) * Infer ResultSet type hints based on DataFormat (#238) * Add SharedMergeTree Cloud tests, remove Node 16 from the CI, and add Node 21 (#234) * Add pathname config option, revert read-only switch/default settings (#251) * Improved performance when decoding the entire set of rows with streamable JSON formats (#253) * Bump dev dependencies, update internal module resolution (#248)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Into 1.0.0. See the changelog entry. Docs will be updated accordingly.
Screencast.from.2024-03-09.08-10-26.webm
Checklist