Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay conversions during data fetching from the data source #270

Merged
merged 3 commits into from
Mar 2, 2020

Conversation

traceon
Copy link
Collaborator

@traceon traceon commented Feb 27, 2020

Added thin wrappers and conversion routines for type categories used during conservative value conversions: WireTypeAnyAsString, WireTypeDateAsInt, WireTypeDateTimeAsInt.

@traceon traceon requested a review from Enmk February 27, 2020 19:16
@traceon traceon changed the title Delay conversions during data fetching from the data source WIP: Delay conversions during data fetching from the data source Feb 28, 2020
@traceon traceon changed the title WIP: Delay conversions during data fetching from the data source Delay conversions during data fetching from the data source Feb 28, 2020
@traceon traceon closed this Feb 28, 2020
@traceon traceon reopened this Feb 28, 2020
@Enmk
Copy link
Collaborator

Enmk commented Mar 2, 2020

Please update PR description to reflect WHY you need those changes.

Copy link
Collaborator

@Enmk Enmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

…onversions: WireTypeAnyAsString, WireTypeDateAsInt, WireTypeDateTimeAsInt

Add/move conversion routines with minimal code duplication for new wrappers
Enable/hardcode conservative value conversions on fetch
@Enmk Enmk merged commit d783b44 into ClickHouse:master Mar 2, 2020
@traceon traceon deleted the delay-conversions branch March 2, 2020 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants