Use descriptors for column binding information #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: Rollback to Nullable(Nothing) for unbound params Actualize the comment Update test/deploy_and_run_clickhouse_macos.sh Fix Null parameter format Switch to ClickHouse version 20.3 as a baseline Fixing Decimal tests and removing them as known fails. Fixes to match known fails. Fixing issue with description formatting. First changes to support TestFlows 1.6
Enmk
reviewed
Jun 26, 2020
Enmk
reviewed
Jun 26, 2020
Enmk
reviewed
Jun 26, 2020
Enmk
approved these changes
Jul 3, 2020
| SQLBindCol( | ||
| hstmt, | ||
| 1, | ||
| getCTypeFor<std::decay_t<decltype(col1[0])>>(), |
There was a problem hiding this comment.
This looks somewhat error prone here, why not just getCTypeFor(col1[0]) ?
There was a problem hiding this comment.
The current getCTypeFor definition will cause the code to fail at compilation, so it is safe. Ugly here, but safe everywhere.
driver/utils/type_info.h
Outdated
| @@ -1813,6 +1813,9 @@ namespace value_manip { | |||
| template <typename SourceType> | |||
| struct from_value { | |||
| static inline SQLRETURN convert(const SourceType & src, BindingInfo & dest) { | |||
| if (dest.indicator && dest.indicator != dest.value_size) | |||
| *dest.indicator = 0; // Value is not null here... | |||
There was a problem hiding this comment.
Not quite sure what indicator means here, could you please add some comments to BindingInfo? Please also specify what does it mean when indicator value is 0.
There was a problem hiding this comment.
Modified the comments.
Reduce row set sizes to reduce test running time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use descriptors for column binding information.
Fix column-wise vs row-wise binding for parameters and implement it for columns.
Implement array bindings for columns.
Closes #235
Closes #296
Doc modification reflects findings in #293
Doc modification reflects versioning issues mentioned in #289
Should help with #299
Should help with #295