Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to ClickHouse version 20.3 as a baseline (changes NULL param string format) #304

Merged
merged 5 commits into from
Jun 24, 2020
Merged

Switch to ClickHouse version 20.3 as a baseline (changes NULL param string format) #304

merged 5 commits into from
Jun 24, 2020

Conversation

traceon
Copy link
Collaborator

@traceon traceon commented Jun 23, 2020 •
edited
Loading

Closes #236
Closes #294
May help with #298 too

This changes are reflecting the following changes in ClickHouse server parameter parsing behavior: ClickHouse/ClickHouse#7488 and ClickHouse/ClickHouse#8517

@traceon traceon requested a review from filimonov June 23, 2020 12:25
@traceon
Copy link
Collaborator Author

traceon commented Jun 23, 2020

parametrized-regression.py-3-dsn-* tests failures can be ignored here, they are addressed separately by #303

@traceon traceon closed this Jun 23, 2020
@traceon traceon reopened this Jun 23, 2020
filimonov
filimonov reviewed Jun 24, 2020
View reviewed changes
driver/statement.cpp Outdated Show resolved Hide resolved
driver/test/statement_parameters_it.cpp Show resolved Hide resolved
test/deploy_and_run_clickhouse_macos.sh Show resolved Hide resolved
test/deploy_and_run_clickhouse_macos.sh Outdated Show resolved Hide resolved
@traceon @filimonov
Update test/deploy_and_run_clickhouse_macos.sh
f221235 
Use 20.5 configs while using 20.5 binary for macOS

Co-authored-by: filimonov <[email protected]>
@traceon traceon changed the title Switch to ClickHouse version 20.3 as a baseline Switch to ClickHouse version 20.3 as a baseline (changes NULL param string format) Jun 24, 2020
filimonov
filimonov approved these changes Jun 24, 2020
View reviewed changes
Copy link
Collaborator

@filimonov filimonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@filimonov filimonov merged commit 333bab4 into ClickHouse:master Jun 24, 2020
@traceon traceon deleted the upgrade-and-fix-clickhouse-version branch June 24, 2020 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filimonov filimonov filimonov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@traceon @filimonov