Ongoing fixes #356
Ongoing fixes #356
Conversation
…on is fixed in upstream" This reverts commit 21bf870.
Silence Disconnect logging
Some refactoring
Add Date/DateTime/DateTime64 testing
driver/connection.cpp
Outdated
| void Connection::verifyConnection() { | ||
| LOG("Verifying connection and credentials..."); | ||
| auto & statement = allocateChild<Statement>(); | ||
| statement.executeQuery("SELECT 1"); |
There was a problem hiding this comment.
Can executeQuery() throw an exception? If yes, will the statement be successfully deallocated later?
There was a problem hiding this comment.
Yeah, I should have added a proper cleanup there. Will fix.
|
|
||
| const auto tmp_type_without_parameters_id = convertUnparametrizedTypeNameToTypeId(tmp_type_name_without_parameters); | ||
|
|
||
| if (huge_int_as_string && tmp_type_without_parameters_id == DataSourceTypeId::UInt64) { |
There was a problem hiding this comment.
What about other wide types, like Int128, UInt128, Decimal128 and wider?
There was a problem hiding this comment.
Int128/UInt128 are not supported in the driver yet. Decimal128 is extracted as string or double anyway (there is no standard Decimal C type), so no need to alter the way it is reported to the ODBC clients.
| void RowBinaryWithNamesAndTypesResultSet::readValue(DataSourceType<DataSourceTypeId::Date> & dest, ColumnInfo & column_info) { | ||
| WireTypeDateAsInt dest_raw; | ||
| WireTypeDateAsInt dest_raw(column_info.timezone); |
There was a problem hiding this comment.
Date has no timezone in CH: https://clickhouse.tech/docs/en/sql-reference/data-types/date/
There was a problem hiding this comment.
Yeah, but the timezone (of the data/server) might be used when it is converted (read by the user) to some DateTime structures.
| @@ -152,14 +153,24 @@ void RowBinaryWithNamesAndTypesResultSet::readValue(WireTypeDateTimeAsInt & dest | |||
| readPOD(dest.value); | |||
| } | |||
|
|
|||
| void RowBinaryWithNamesAndTypesResultSet::readValue(WireTypeDateTime64AsInt & dest, ColumnInfo & column_info) { | |||
| readPOD(dest.value); | |||
There was a problem hiding this comment.
Did you forget to use\convert value according to a timezone?
There was a problem hiding this comment.
It should be done later on the call stack (TODO yet, not the goal of this PR):
driver/test/datetime_it.cpp
Outdated
|
|
||
| class DateTime | ||
| : public ClientTestWithParamBase< | ||
| std::tuple< |
There was a problem hiding this comment.
IMO it is better to use named struct here, it is easier to read and reason about.
* master: Bump submodules Rewrite workflows Test action
…tion string parameter values
|
GCC builds in macOS are failing due to nanodbc - a fix for that was proposed in their repo, once (and if) it is merged and submodule here is bumped, these failures will be gone. For now, it is fairly safe to merge with those builds failing. |
README.mdVerifyConnectionEarlyfunctionality to enable extra check onSQLConnect()HugeIntAsStringfunctionality