Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CHANGELOG, fix clippy issues #150

Merged
merged 5 commits into from
Sep 23, 2024
Merged

Update CHANGELOG, fix clippy issues #150

merged 5 commits into from
Sep 23, 2024

Conversation

slvrtrn
Copy link
Contributor

@slvrtrn slvrtrn commented Sep 12, 2024

Covers the changes from #139, #140, #141

Needs updates regarding #156

@slvrtrn slvrtrn changed the title Update CHANGELOG, README Update CHANGELOG, README, fix clippy issues Sep 12, 2024
@slvrtrn
Copy link
Contributor Author

slvrtrn commented Sep 12, 2024

@serprex, can you please verify that I documented the changes from #140, #141 correctly?

serprex
serprex previously approved these changes Sep 12, 2024
Copy link
Member

@serprex serprex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wording a bit confusing since 140/141 kinda conflict, but gets there in the end

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@slvrtrn slvrtrn changed the title Update CHANGELOG, README, fix clippy issues Update README, fix clippy issues Sep 23, 2024
@slvrtrn slvrtrn changed the title Update README, fix clippy issues Update CHANGELOG, fix clippy issues Sep 23, 2024
@loyd loyd merged commit b85d1df into main Sep 23, 2024
6 checks passed
@loyd loyd deleted the update-changelog-and-readme branch September 23, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants