Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't drop local tables when there is no distributed table #363

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

canbekley
Copy link
Contributor

Summary

Current distributed incremental runs will drop local production tables when the distributed tables are missing. This can cause irrevesable data loss.

The proposed fix will only drop and create local tables if they actually don't exist in clickhouse. Distributed tables will be created if they are missing (for any reason).

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

@canbekley
Copy link
Contributor Author

@BentsiLeviav I added a changelog for this as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant