Implement combined retentions with backward compatibility #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Felixoid
force-pushed
the
combined_rollup
branch
2 times, most recently
from
1aa86ab
to
4b7e2ab
Compare
Felixoid
commented
Mar 8, 2019
src/main/java/ru/yandex/market/graphouse/retention/MetricRetention.java
Outdated
Show resolved
Hide resolved
Felixoid
force-pushed
the
combined_rollup
branch
from
e78b4f8
to
83bb144
Compare
AndreevDm
reviewed
May 10, 2019
src/main/java/ru/yandex/market/graphouse/retention/MetricRetention.java
Outdated
Show resolved
Hide resolved
src/main/java/ru/yandex/market/graphouse/retention/CombinedRetentionProvider.java
Outdated
Show resolved
Hide resolved
src/main/java/ru/yandex/market/graphouse/retention/MetricRetention.java
Outdated
Show resolved
Hide resolved
Felixoid
force-pushed
the
combined_rollup
branch
4 times, most recently
from
c83b9f5
to
79ee489
Compare
|
/ping |
Felixoid
force-pushed
the
combined_rollup
branch
from
79ee489
to
3dc5cc2
Compare
AndreevDm
suggested changes
Jul 28, 2019
There was a problem hiding this comment.
Что надо поправить архитектурно:
- Не складывать в MetricRetention паттерны, они не должны выходить за пределы RetentionProvider
- Не пытаться складывать готовые MetricRetention в List, и потом проходить по нему в поиске нужного Retention. Это приведет к тому, что количество проверяемых будет перемножаться. Нет ничего страшного в создании нового объекта MetricRetention каждую метрику, дерево всё равно кешируемое и будет вычищаться из памяти. Прикапывать их в теории тоже можно, но я предлагаю сейчас на это вообще не заморачиваться. Кроме того вся эта конструкция сейчас не ThreadSafe.
Felixoid
force-pushed
the
combined_rollup
branch
from
fb366ae
to
52bd40e
Compare
Распилил на два класса, тесты адаптировал |
AndreevDm
reviewed
Aug 7, 2019
src/main/java/ru/yandex/market/graphouse/retention/MetricRetentionConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/ru/yandex/market/graphouse/retention/MetricRetentionConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/ru/yandex/market/graphouse/retention/CombinedRetentionProvider.java
Outdated
Show resolved
Hide resolved
src/main/java/ru/yandex/market/graphouse/retention/CombinedRetentionProvider.java
Outdated
Show resolved
Hide resolved
src/main/java/ru/yandex/market/graphouse/retention/CombinedRetentionProvider.java
Outdated
Show resolved
Hide resolved
AndreevDm
approved these changes
Aug 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements feature from ClickHouse/ClickHouse#4426:
Retention and Aggregation patterns now could be described separately.