Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve examples, make them part of e2e tests #140

Merged
merged 8 commits into from
Aug 22, 2024
Merged

Improve examples, make them part of e2e tests #140

merged 8 commits into from
Aug 22, 2024

Conversation

whites11
Copy link
Contributor

@whites11 whites11 commented Aug 20, 2024 •
edited
Loading

this huge PR:

  • changes the folder structure of the usage examples and made them self sufficient (i.e. runnable without changes). End goal is to make it easier to test by customers.
  • runs the private_link examples during e2e tests (aws only, azure and GCP will follow)
  • improves public docs, those published on terraform own pages.

@whites11
Refactor examples structure.
c4d33dc 
Run private link test as part of e2e
@whites11
Refactor examples structure.
1abb9f5 
Run private link test as part of e2e
@whites11 whites11 marked this pull request as ready for review August 21, 2024 12:27
@whites11 whites11 requested a review from a team as a code owner August 21, 2024 12:27
@whites11 whites11 self-assigned this Aug 21, 2024
@tsolodov tsolodov self-requested a review August 21, 2024 22:24
jkaflik
jkaflik approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@jkaflik jkaflik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.github/actions/cleanup/action.yaml Outdated Show resolved Hide resolved
.github/actions/e2e/action.yaml Show resolved Hide resolved
docs/index.md Show resolved Hide resolved
@whites11 whites11 merged commit bb0b590 into main Aug 22, 2024
25 of 26 checks passed
@whites11 whites11 deleted the examples branch August 22, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkaflik jkaflik jkaflik approved these changes

@guykoh guykoh guykoh approved these changes

@tsolodov tsolodov Awaiting requested review from tsolodov

Assignees

@whites11 whites11

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@whites11 @jkaflik @guykoh