Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve retry logic #143

Merged
merged 6 commits into from
Aug 23, 2024
Merged

Improve retry logic #143

merged 6 commits into from
Aug 23, 2024

Conversation

whites11
Copy link
Contributor

@whites11 whites11 commented Aug 22, 2024 •
edited
Loading

Towards: #133

This PR:

  • Replaces own code with backoff library for backoff type use cases
  • Add automatic retry of 429 and 5xx errors

as a side effect this PR makes end to end tests dramatically more reliable

@whites11
Use library for backoff retries instead of own code.
7811225 
Add automatic retry of 429 and 5xx errors
@whites11
Use library for backoff retries instead of own code.
7b0104e 
Add automatic retry of 429 and 5xx errors
@whites11
Use library for backoff retries instead of own code.
355a1f2 
Add automatic retry of 429 and 5xx errors
@whites11 whites11 changed the title Use library for backoff retries instead of own code. Improve retry logic Aug 22, 2024
@whites11
Use library for backoff retries instead of own code.
616efb6 
Add automatic retry of 429 and 5xx errors
@whites11
Use library for backoff retries instead of own code.
b8df127 
Add automatic retry of 429 and 5xx errors
@whites11 whites11 marked this pull request as ready for review August 22, 2024 15:31
@whites11 whites11 requested a review from a team as a code owner August 22, 2024 15:31
@whites11
Use library for backoff retries instead of own code.
0c7ee4e 
Add automatic retry of 429 and 5xx errors
@whites11 whites11 enabled auto-merge (squash) August 22, 2024 15:34
@whites11 whites11 self-assigned this Aug 22, 2024
nikita-vanyasin
nikita-vanyasin approved these changes Aug 22, 2024
View reviewed changes
pkg/internal/api/client.go Show resolved Hide resolved
pkg/internal/api/client.go Show resolved Hide resolved
pkg/internal/api/client.go Show resolved Hide resolved
pkg/internal/api/client.go Show resolved Hide resolved
@whites11 whites11 merged commit a6af408 into main Aug 23, 2024
4 checks passed
@whites11 whites11 deleted the backoff-retry branch August 23, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikita-vanyasin nikita-vanyasin nikita-vanyasin approved these changes

Assignees

@whites11 whites11

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@whites11 @nikita-vanyasin