Dynamically detect non-time dims in regrid #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes failing distributed regrid regional writes to zarr store when input data has variable that is not "lat" or "lon" and does not depend on "time" dim. The error appears because all data regionally written to the zarr needs to depend on "time". The solution is to dynamically figure out which variables do or do not depend on time. Previously, this depended on a static, user-provided list of variables to exclude. close #494
|
Potential alternative to ClimateImpactLab/dodola#177 |
|
A test run of this change, using the data from #494 is here: https://argo.cildc6.org/workflows/default/distributed-regrid-dev-27wlw |
|
Thanks for this alternative @brews, I will take a look in a bit ! |
emileten
approved these changes
Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes failing distributed regrid regional writes to zarr store when input data has variable that is not "lat" or "lon" and does not depend on "time" dim.
The error appears because all data regionally written to the zarr needs to depend on "time". The solution is to dynamically figure out which variables do or do not depend on time. Previously, this depended on a static, user-provided list of variables to exclude.
close #494