Fix write-to-copy warning in process_rff_sample() #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brews
changed the title
Codecov Report
@@ Coverage Diff @@
## main #116 +/- ##
=======================================
Coverage 70.33% 70.33%
=======================================
Files 17 17
Lines 1847 1847
=======================================
Hits 1299 1299
Misses 548 548
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
JMGilbert
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #114
I think this avoids the problem. Test covering this passes but I don't think it tested the case if input data has NA/ NaNs so someone please tell me if I missed something.