Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installing error due to PyYaml version #123

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

northwestwitch
Copy link
Member

@northwestwitch northwestwitch commented Oct 25, 2023

This PR adds | fixes:

Check also the issue on the PyYAML repo: yaml/pyyaml#724

How to test:

  • Run pip install -e . from main branch and this branch

Expected outcome:

  • The repo should install using this branch

Review:

  • Code approved by
  • Tests executed by CR

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@northwestwitch
Copy link
Member Author

Master branch: 🚫

image

This branch: 🆗

image

@dnil
Copy link
Collaborator

dnil commented Oct 25, 2023

The change looks good to me, and passes tests. Did you try something a bit yaml related specifically while testing? I suppose there are configs to read and what not?

In general, it looks like this package has inordinately many frozen dependency versions. I can understand cyvcf2 perhaps, but... 😆

@northwestwitch
Copy link
Member Author

In general, it looks like this package has inordinately many frozen dependency versions. I can understand cyvcf2 perhaps, but... 😆

Yeah, I agree

@dnil
Copy link
Collaborator

dnil commented Oct 25, 2023

And I forgot to hit "approve"... Time for some food. 😆

@northwestwitch
Copy link
Member Author

That's weird, I don't find anywhere in the code where PyYaml is used..

The change looks good to me, and passes tests. Did you try something a bit yaml related specifically while testing? I suppose there are configs to read and what not?

Tested with a simple config file to connect to my local db:

yaml file content:
image

image

@northwestwitch northwestwitch merged commit ffd0df3 into master Oct 25, 2023
2 checks passed
@northwestwitch northwestwitch deleted the fix_deprecated_config branch October 25, 2023 10:41
@dnil
Copy link
Collaborator

dnil commented Oct 25, 2023

Here, I think, so testing config was a good call. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecated config in setup.cfg
2 participants