Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 4.5.1 #1234

Merged
merged 4 commits into from
May 28, 2019
Merged

Release 4.5.1 #1234

merged 4 commits into from
May 28, 2019

Conversation

northwestwitch
Copy link
Member

@northwestwitch northwestwitch commented May 28, 2019

Small fixes:

  • update requirement to use PyYaml version >= 5.1

  • Safer code when loading config params in cli base

  • Approved for merge and deploy by @ingkebil

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3500

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.612%

Changes Missing Coverage Covered Lines Changed/Added Lines %
scout/version.py 0 1 0.0%
Totals Coverage Status
Change from base Build 3495: 0.0%
Covered Lines: 8001
Relevant Lines: 11331

💛 - Coveralls

@ingkebil
Copy link

Some remarks:

  • you're releasing two fixes even though the intended release was for one fix only.
  • the second fix has not been tested.

I will approve the merge and deploy now and I would suggest that if you want to be able to release small fixes like this, you either switch properly to git flow (and add a development branch) which would have allowed you to release only the intended fix and keep the other minor change for your next release.
If you do not think git flow works out for you, you can always switch to a rolling release cycle by using github flow.
Both are described in detail here: http://www.clinicalgenomics.se/development/dev/models/

Let me know if you need any help! :)

@northwestwitch
Copy link
Member Author

Thanks. The other fix (safer base cli) was tested, approved and merged into master already (it was already in the readme).

Every time we have released a new version of Scout we have been describing in the readme everything that has changed from the previous version. I think this is really good if you want to keep track of all the changes at the release level.

Regarding the 2 models (git flow and rolling release) I think we have to have a discussion about it with @dnil @moonso and @henrikstranneheim (if he wants). But I'll read the documentation!

@northwestwitch
Copy link
Member Author

Could someone approve @ingkebil @moonso @dnil ? Thanks!

Copy link
Collaborator

@dnil dnil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dnil
Copy link
Collaborator

dnil commented May 28, 2019

Dont forget to motivate the minor version change! 😉

@northwestwitch
Copy link
Member Author

👍

Thanks!!!

@northwestwitch northwestwitch merged commit c9b3ec1 into master May 28, 2019
@ingkebil
Copy link

Feel free to deploy on clinical-db. I'll deploy later today on hasta. I will also remove the restriction to deploy scout on hasta so you can do it.

@northwestwitch
Copy link
Member Author

Thanks!

@ingkebil
Copy link

It's deployed on hasta now

@northwestwitch
Copy link
Member Author

Great, thanks! @adrosenbaum whatever you need to test should work now :)

@northwestwitch northwestwitch deleted the release_4.5.1 branch June 4, 2019 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants