-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 4.5.1 #1234
Release 4.5.1 #1234
Conversation
Pull Request Test Coverage Report for Build 3500
💛 - Coveralls |
Some remarks:
I will approve the merge and deploy now and I would suggest that if you want to be able to release small fixes like this, you either switch properly to git flow (and add a development branch) which would have allowed you to release only the intended fix and keep the other minor change for your next release. Let me know if you need any help! :) |
Thanks. The other fix (safer base cli) was tested, approved and merged into master already (it was already in the readme). Every time we have released a new version of Scout we have been describing in the readme everything that has changed from the previous version. I think this is really good if you want to keep track of all the changes at the release level. Regarding the 2 models (git flow and rolling release) I think we have to have a discussion about it with @dnil @moonso and @henrikstranneheim (if he wants). But I'll read the documentation! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Dont forget to motivate the minor version change! 😉 |
Thanks!!! |
Feel free to deploy on clinical-db. I'll deploy later today on hasta. I will also remove the restriction to deploy scout on hasta so you can do it. |
Thanks! |
It's deployed on hasta now |
Great, thanks! @adrosenbaum whatever you need to test should work now :) |
Small fixes:
update requirement to use PyYaml version >= 5.1
Safer code when loading config params in cli base
Approved for merge and deploy by @ingkebil