Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nupkg generation #96

Merged
merged 2 commits into from
Jul 16, 2019
Merged

Fix nupkg generation #96

merged 2 commits into from
Jul 16, 2019

Conversation

Pankraty
Copy link
Member

@Pankraty Pankraty commented Jul 15, 2019

This PR replaces licenseUrl (deprecated) with license tag. See NuGet/Home#4628 for more information.

Also, I noticed that the icon is missing in the generated .nupkg if its URL is specified in .nuspec. Specifying it in .csproj fixes the issue.

The following screenshot made from the AppVeyor build for this PR:

image

@b0bi79 b0bi79 merged commit 230d148 into ClosedXML:develop Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants