fix: properly close buffers to prevent memory leaks #1146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derklaro
added
v: 4.X
0utplay
approved these changes
Mar 10, 2023
derklaro
added a commit
that referenced
this pull request
Mar 14, 2023
### Motivation The current way we handle data bufs is prone to memory "leaks". They are not noticeable by the user directly, as the underlying memory of a buffer gets cleaned when it becomes phantom-reachable, but if a process is allowed to allocate a lot of memory, the consumed memory will rise until the garbage collector takes action (which can be very late considering that we set ZGC as the default in our start scripts). ### Modification Change the complete internal code in a way that no more memory leaks are occurring. Note that this change might be error prone, as external plugins might use buffers in an invalid way that causes issues after the change. External code is now required to acquire and release a buffer to ensure it's not getting closed, rather than keeping a reference which prevents the buffer from getting released. ### Result No more internal memory leaks.
derklaro
added a commit
that referenced
this pull request
Apr 17, 2023
### Motivation The current way we handle data bufs is prone to memory "leaks". They are not noticeable by the user directly, as the underlying memory of a buffer gets cleaned when it becomes phantom-reachable, but if a process is allowed to allocate a lot of memory, the consumed memory will rise until the garbage collector takes action (which can be very late considering that we set ZGC as the default in our start scripts). ### Modification Change the complete internal code in a way that no more memory leaks are occurring. Note that this change might be error prone, as external plugins might use buffers in an invalid way that causes issues after the change. External code is now required to acquire and release a buffer to ensure it's not getting closed, rather than keeping a reference which prevents the buffer from getting released. ### Result No more internal memory leaks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The current way we handle data bufs is prone to memory "leaks". They are not noticeable by the user directly, as the underlying memory of a buffer gets cleaned when it becomes phantom-reachable, but if a process is allowed to allocate a lot of memory, the consumed memory will rise until the garbage collector takes action (which can be very late considering that we set ZGC as the default in our start scripts).
Modification
Change the complete internal code in a way that no more memory leaks are occurring. Note that this change might be error prone, as external plugins might use buffers in an invalid way that causes issues after the change. External code is now required to acquire and release a buffer to ensure it's not getting closed, rather than keeping a reference which prevents the buffer from getting released.
Result
No more internal memory leaks.