fix: ignore http requests with an opaque uri #1181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derklaro
added
v: 4.X
0utplay
approved these changes
Apr 11, 2023
derklaro
added a commit
that referenced
this pull request
Apr 17, 2023
### Motivation Opaque URIs are a type of URI that does not allow access to the underlying resource. Instead, the opaque URI contains a string of characters that represent the resource, but the handler has no information about how to access or manipulate that resource. As our http handler design is based on the assumption that the path to the resource to call is present, we cannot handle requests that are opaque at all. ### Modification Early deny requests that are sending an opaque request and respond with status 400 (bad request) to them. ### Result There are no more requests processed that cannot get handled and are causing exceptions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Opaque URIs are a type of URI that does not allow access to the underlying resource. Instead, the opaque URI contains a string of characters that represent the resource, but the handler has no information about how to access or manipulate that resource. As our http handler design is based on the assumption that the path to the resource to call is present, we cannot handle requests that are opaque at all.
Modification
Early deny requests that are sending an opaque request and respond with status 400 (bad request) to them.
Result
There are no more requests processed that cannot get handled and are causing exceptions.