Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to aerogel v3 #1524

Open
wants to merge 10 commits into
base: nightly
Choose a base branch
from
Open

feat: upgrade to aerogel v3 #1524

wants to merge 10 commits into from

Conversation

0utplay
Copy link
Member

@0utplay 0utplay commented Oct 7, 2024

Motivation

Aerogel 3 was released and we should upgrade.

Modification

Upgraded to aerogel v3 and addressed the needed changes

Result

Aerogel 3 is used.

@0utplay 0utplay added v: 4.X This pull should be included in the 4.0 release in: node An issue/pull request releated to the node module code in: driver An issue/pull request releated to the driver module code t: improvement The pull request improves existing code labels Oct 7, 2024
@0utplay 0utplay added this to the 4.0.0-RC11 milestone Oct 7, 2024
@0utplay 0utplay requested a review from derklaro October 7, 2024 19:03
@0utplay 0utplay self-assigned this Oct 7, 2024
Copy link

github-actions bot commented Oct 7, 2024

Test Results

 48 files  ±0   48 suites  ±0   1m 47s ⏱️ ±0s
420 tests ±0  420 ✅ ±0  0 💤 ±0  0 ❌ ±0 
751 runs  ±0  751 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 0df0c9d. ± Comparison against base commit cdfa55e.

This pull request removes 36 and adds 36 tests. Note that renamed tests count towards both.
eu.cloudnetservice.driver.document.DocumentSerialisationTest ‑ [4] {"b":1,"s":2,"i":3,"l":4,"f":5.0,"d":6.0,"c":"/","string":"Hello, World!","bol":true,"cloud":["Ben?","Yes","No","HoHoHoHo"],"world":{"this":"is","insane":"!","hello":"world"}}, PRETTY
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [14] 2024-10-21
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [23] 12:16:44.427047257
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [28] 12:16:44.427360251Z
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [29] 12:16:44.427394995Z
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [30] 12:16:44.427418610+05:00
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [31] 12:16:44.427442494-03:00
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [34] 2024-10-21T12:16:44.427465907
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [39] 2024-10-21T12:16:44.427608163Z
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [4] 2024-10-21T12:16:44.426926202Z
…
eu.cloudnetservice.driver.document.DocumentSerialisationTest ‑ [4] {"b":1,"s":2,"i":3,"l":4,"f":5.0,"d":6.0,"c":"/","string":"Hello, World!","bol":true,"cloud":["Ben?","Yes","No","HoHoHoHo"],"world":{"hello":"world","insane":"!","this":"is"}}, PRETTY
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [14] 2024-10-24
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [23] 18:07:54.877138538
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [28] 18:07:54.877290303Z
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [29] 18:07:54.877315781Z
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [30] 18:07:54.877343192+05:00
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [31] 18:07:54.877502552-03:00
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [34] 2024-10-24T18:07:54.877535353
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [39] 2024-10-24T18:07:54.877660689Z
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [4] 2024-10-24T18:07:54.877020857Z
…

♻️ This comment has been updated with latest results.

@derklaro derklaro modified the milestones: 4.0.0-RC11, 4.0.0-RC12 Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: driver An issue/pull request releated to the driver module code in: node An issue/pull request releated to the node module code t: improvement The pull request improves existing code v: 4.X This pull should be included in the 4.0 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants