Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipc: Retry receiving credentials if the the message is short #476

Merged
merged 2 commits into from
Nov 25, 2022
Merged

ipc: Retry receiving credentials if the the message is short #476

merged 2 commits into from
Nov 25, 2022

Conversation

chrissie-c
Copy link
Contributor

bz#2111711

kgaillot
kgaillot reviewed Nov 7, 2022
View reviewed changes
Copy link
Contributor

@kgaillot kgaillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

lib/ipc_setup.c Outdated Show resolved Hide resolved
jfriesse
jfriesse reviewed Nov 7, 2022
View reviewed changes
Copy link
Member

@jfriesse jfriesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor detail about magic constant, otherwise looks good and make sense.

lib/ipc_setup.c Outdated
res = qb_ipc_us_recv_msghdr(data);
if (res == -EAGAIN && ++retry_count < 10) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's minor detail, but could we change magic constant (10) to constant? Same probably with usleep time (100000)?

@chrissie-c
ic: Use nanosleep() instead of usleep()
5befe23 
use #defines for 'magic' numbers
jfriesse
jfriesse approved these changes Nov 9, 2022
View reviewed changes
Copy link
Member

@jfriesse jfriesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@chrissie-c chrissie-c merged commit 5594d37 into ClusterLabs:main Nov 25, 2022
@chrissie-c chrissie-c deleted the retry-short-creds branch November 25, 2022 07:50
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Jun 21, 2023
@bmwiedemann
Update libqb to version 2.0.7+20230607.06c8641 / rev 35 via SR 1093859
bb431ab 
https://build.opensuse.org/request/show/1093859
by user yan_gao + dimstar_suse
- Update to version 2.0.7+20230607.06c8641 (v2.0.7):
- blackbox: fix potential overlow/memory corruption (gh#ClusterLabs/libqb#486)
- tests: allow -j to work (gh#ClusterLabs/libqb#485)
- strlcpy: avoid compiler warning from strncpy (gh#ClusterLabs/libqb#473)
- timer: Move state check to before time check (gh#ClusterLabs/libqb#479)
- ipc: Retry receiving credentials if the the message is short (gh#ClusterLabs/libqb#476, rh#2111711)
- lib: Fix some small bugs spotted by newest covscan (gh#ClusterLabs/libqb#471)
- doxygen2man: Fix function parameter alignment (gh#ClusterLabs/libqb#468) (forwarded request 1093858 from yan_gao)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgaillot kgaillot kgaillot left review comments

@jfriesse jfriesse jfriesse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrissie-c @jfriesse @kgaillot