Skip to content

Commit

Permalink
Change default development_region from "English" to "en" because "Eng…
Browse files Browse the repository at this point in the history
…lish" is deprecated in Xcode 10.2
  • Loading branch information
Steffen Matthischke committed Mar 27, 2019
1 parent 0ec1f7f commit 4e32a04
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@
* Normalize xcconfig path when generating includes.
[bclymer](https://github.com/bclymer)

* Use modern localization identifier 'en' for the development region.
[Steffen Matthischke](https://github.com/heeaad)

## 1.8.1 (2019-02-19)

##### Enhancements
Expand Down
2 changes: 1 addition & 1 deletion lib/xcodeproj/project/object/root_object.rb
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ class PBXProject < AbstractObject

# @return [String] the development region of the project.
#
attribute :development_region, String, 'English'
attribute :development_region, String, 'en'

# @return [String] whether the project has scanned for encodings.
#
Expand Down
2 changes: 1 addition & 1 deletion spec/project/object/root_object_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ module ProjectSpecs
end

it 'returns the development region' do
@root_object.development_region.should == 'English'
@root_object.development_region.should == 'en'
end

it 'returns whether has scanned for encodings' do
Expand Down

0 comments on commit 4e32a04

Please sign in to comment.