PBXNativeTarget.add_dependency support for subproject targets #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| end | ||
|
|
||
| it "does not find references by relative path" do | ||
| lambda { @project.reference_for_path(@project.path.basename) }.should.raise ArgumentError |
There was a problem hiding this comment.
We tend to implement this as:
should.raise ArgumentError do
@project.reference_for_path(@project.path.basename)
end.message.should.match /not this project/
|
This patch looks great! Could you update the changelog crediting yourself? |
|
Thanks for reviewing! I added the style fixes as a separate commit. I can amend them into the original two commits if you prefer. |
added 3 commits
October 17, 2013 12:43
It mirrors the functionality of the method with the same name in CocoaPod's Pod::Project class (which after this patch will override it). The differences are 1) CocoaPod's implementation is constant time but this is linear wrt the number of objects, 2) CocoaPod's implementation does not work when you load a previously existing file.
Previously, the behavior was simply to silently create an invalid Xcode project file that Xcode UI showed as if the dependency wasn't added.
|
Nevermind I found that I forgot a fix anyway. I have now rebased my commits so that they are nice and clean and force pushed the new branch. I'm not too familiar with the GitHub workflow, I hope that this doesn't mess things up. |
|
Looks great. Thank you! |
alloy
added a commit
that referenced
this pull request
Oct 17, 2013
PBXNativeTarget.add_dependency support for subproject targets
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This part of my work on CocoaPods/CocoaPods#1024.
I do this in order to sanely be able to make the Pod target depend sanely on the subproject target(s).