Scheme fixes #102
Scheme fixes #102
Conversation
| build_target.name | ||
| else | ||
| raise ArgumentError, "Unsupported build target type #{build_target.isa}" | ||
| end |
There was a problem hiding this comment.
I would prefer the use of case...when...else...end here.
|
If you can fix that one style issue and fix the CHANGELOG merge conflict now that the other PR has been merged, then this can go in as well. Thanks again for your work! |
Before this patch, the method would raise an error on aggregate targets. The method still doesn't support PBXLegacyTargets, since I don't know how they behave.
Generate correct ReferencedContainer attribute when the Xcode project has a non-empty `projectDirPath`. The ReferencedContainer attribute is actually relative to the projectDirPath. I ran into a problem where Xcode would generate duplicate schemes of the hidden schemes that are generated by CocoaPods because the ReferencedContainer attribute that CocoaPods generates was different from what Xcode generated on an Xcode project that was generated by Cmake in a certain way.
|
Thanks. The reason I'm working on this is that I want to add support for adding subprojects to podspecs, as discussed in CocoaPods#1024. It would be valuable to get feedback on whether this is a direction you would like to go. The new podspec syntax I have created looks like this |
|
Changes Unknown when pulling cda4873 on pereckerdal:scheme_fixes into * on CocoaPods:master*. |
|
Thanks for the changes! Regarding CocoaPods/CocoaPods#1024, I would like to have that in, but there is likely going to be more details to figure out and @irrationalfab has some reservations regarding directly using the Xcode project or extracting useful info from it. The use-case you describe, however, is a reason why I would like this to work. Please continue and report all your findings on that ticket! /cc @0xced |
This branch fixes a bug in the ReferencedContainer attribute generation in Scheme and adds support for aggregate build targets in the scheme generation. (Before, it would raise an error when generating hidden schemes for projects that have aggregate targets)
This will probably have a merge conflict in CHANGELOG.md if merged after my reference_for_path branch. I don't know what the nicest way to do this in GitHub is, this was the best way I could come up with.