Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't add Frameworks to project by default #142

Closed
wants to merge 1 commit into from
Closed

Don't add Frameworks to project by default #142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions lib/xcodeproj/project/project_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,6 @@ def self.new_target(project, type, name, platform, deployment_target, product_gr
target.build_phases << project.new(PBXSourcesBuildPhase)
target.build_phases << project.new(PBXFrameworksBuildPhase)

# Frameworks
framework_name = (platform == :ios) ? 'Foundation' : 'Cocoa'
framework_ref = target.add_system_framework(framework_name)

target
end

Expand Down
8 changes: 2 additions & 6 deletions spec/project/object/native_target_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,11 +246,7 @@ module ProjectSpecs
end

phase.should.be.instance_of klass
if phase.is_a? PBXFrameworksBuildPhase
phase.files.count.should == 1
else
phase.files.to_a.should == []
end
phase.files.to_a.should == []
end
end

Expand Down Expand Up @@ -377,7 +373,7 @@ module ProjectSpecs
pretty_print = @sut.pretty_print
pretty_print['Pods']['Build Phases'].should == [
{ "SourcesBuildPhase" => [] },
{ "FrameworksBuildPhase" => ["Foundation.framework"] }
{ "FrameworksBuildPhase" => [] }
]
build_configurations = pretty_print['Pods']['Build Configurations']
build_configurations.map { |bf| bf.keys.first } .should == ["Release", "Debug"]
Expand Down