Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump last known versions. #253

Merged
merged 7 commits into from
Apr 27, 2015
Merged

Bump last known versions. #253

merged 7 commits into from
Apr 27, 2015

Conversation

neonichu
Copy link
Member

Xcode 6.3 brings a new project format:
screen shot 2015-03-24 at 22 04 33

While at it, I also bumped other "last known" constants.

Why is this WIP? Bumping LAST_KNOWN_OBJECT_VERSION would mean that older Xcode's wouldn't be compatible anymore - I guess we should have two constants now? Using the older one for generating project files, but not erroring for 6.3 ones?

@neonichu
Copy link
Member Author

BTW, haven't found what is actually different in the "new" format, seems to be identical for some project files I tested, except for the versioning constant.

@kylef
Copy link
Contributor

kylef commented Mar 24, 2015

Let's hold off with this until 6.3 GM is out.

@kylef
Copy link
Contributor

kylef commented Mar 24, 2015

Also, perhaps we can introspect the user's project to determine which version to use.

@neonichu
Copy link
Member Author

neonichu commented Apr 9, 2015

So 6.3 is out now. Introspection is already happening if an existing project is opened. The open question is: what to do if there isn't?

  1. Default to latest version, 6.3, this is how we have been doing it.
  2. Default to the 3.2 format.

Additionally, we could allow to pass in an object version to the Project initializer - that would allow CP to generate the Pods project with the same version as the user project.

@AliSoftware
Copy link
Contributor

Same as user project seems the most logical choice IMHO.

@neonichu neonichu changed the title WIP: Bump last known versions. Bump last known versions. Apr 20, 2015
@neonichu
Copy link
Member Author

This is now ready to be merged.

Using the old 3.2 format is the default for completely new projects, when opening projects the current format is retained. There is also a new parameter to the initializer which will enable CP to infer the format from the user project.

@neonichu
Copy link
Member Author

@mrackwitz @kylef what do you think?

@segiddins
Copy link
Member

👍 @neonichu please bring home this integration in CocoaPods?

neonichu added a commit that referenced this pull request Apr 27, 2015
@neonichu neonichu merged commit 6dbb3c7 into master Apr 27, 2015
@neonichu neonichu deleted the 6.3-format branch April 27, 2015 14:57
neonichu added a commit to CocoaPods/CocoaPods that referenced this pull request Apr 27, 2015
neonichu added a commit to CocoaPods/CocoaPods that referenced this pull request Apr 27, 2015
@jakepetroules
Copy link

Did you guys ever find out what actually changed in the 6.3 format?

@neonichu
Copy link
Member Author

Nope, did you find anything?

@yar1vn
Copy link

yar1vn commented Sep 30, 2016

Any updates on the Xcode project format? Had the same issue this week and went back to 3.2 but took my a while to figure it out. Thought the podfile was broken at first.

@pichirichi
Copy link

Same happen now with Xcode 8.0, when changed back to Xcode 6.3 all is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants