Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add XCScheme#save! to save scheme in place #308

Merged
merged 3 commits into from
Sep 26, 2015
Merged

Add XCScheme#save! to save scheme in place #308

merged 3 commits into from
Sep 26, 2015

Conversation

AliSoftware
Copy link
Contributor

When initialized from an existing *.xcscheme file, this allows to modify the existing schemes and save them more easily — as in such cases, the save_as (taking the path to the xcodeproj + scheme name as separate parameters) is not the most appropriate:

s = Xcodeproj::XCScheme.new(some_path)
# … play with s, modify stuff
s.save!

@AliSoftware AliSoftware changed the title Add XCScheme#save! to save in place (when initialized from an existing file) Add XCScheme#save! to save scheme in place Sep 26, 2015
segiddins
segiddins reviewed Sep 26, 2015
View reviewed changes
lib/xcodeproj/scheme.rb
@doc = REXML::Document.new(File.new(file_path))
@doc.context[:attribute_quote] = :quote

@scheme = @doc.elements['Scheme']
else
@file_path = nil
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is unecessary

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I knew you would say that, damn ^^

@segiddins
Copy link
Member

👍 other than my one comment

AliSoftware added a commit that referenced this pull request Sep 26, 2015
@AliSoftware
Merge pull request #308 from CocoaPods/ali-xcscheme-save-in-place
557ca1b 
Add `XCScheme#save!` to save scheme in place
@AliSoftware AliSoftware merged commit 557ca1b into master Sep 26, 2015
@AliSoftware AliSoftware deleted the ali-xcscheme-save-in-place branch September 26, 2015 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
s4:awaiting validation t1:enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AliSoftware @segiddins