Add a method to create a new PBXVariantGroup in a group #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me |
|
|
||
| * Add method to create new variant groups (groups for localized versions of the same file) | ||
| [Tim Bodeit](https://github.com/timbodeit) | ||
| [Xcodeproj#301](https://github.com/CocoaPods/Xcodeproj/pull/315) |
There was a problem hiding this comment.
is this supposed to be 301 or 315? Also, needs an extra newline here
There was a problem hiding this comment.
Very good catch! I think I copied the line to match the rest of the changelog and only changed one of the PR numbers 😔
|
👍 other than comment |
|
|
segiddins
added a commit
that referenced
this pull request
Oct 15, 2015
Add a method to create a new PBXVariantGroup in a group
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used for fixing CocoaPods/CocoaPods#2597
Please provide feedback on the test coverage.