Adjust Xcodeproj::Workspace to keep the underlying REXML document and add basic <Group> support. #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| # @param [Array] file_references @see file_references | ||
| # @return [Array<GroupReference>] the groups contained in the workspace |
There was a problem hiding this comment.
Are you saying the @return should still be @param?
|
@AliSoftware could you review this, please? |
| @schemes = {} | ||
| if !document || document.is_a?(REXML::Document) |
There was a problem hiding this comment.
prefer document.nil? to !document
|
Please add an entry in CHANGELOG as well. |
|
I believe all the remarks are addressed - let me know if there's anything else that looks suspect or needs additional clarification/work |
AliSoftware
added a commit
that referenced
this pull request
Oct 27, 2015
Adjust Xcodeproj::Workspace to keep the underlying REXML document and add basic <Group> support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.