Add support for scheme environment variables

[justinseanmartin]

This resolves issue #325.

Aside from the stuff directly related to environment variables, I did some rubocop cleanup. After rebasing, the changes are mostly moot due to other changes to the .rubocop_cocoapods.yml. I also reran rubocop --auto-gen-config, which looks like it hasn't been run in a while. I can break these changes out to a separate PR, or remove them entirely if you'd prefer. LMK.

🌈 (after the fact)

[AliSoftware]

I believe the YARD documentation syntax expect Array<EnvironmentVariable>, see http://yardoc.org/types.html for a quick cheat sheet.

[justinseanmartin]

Yep, you're right. First time for YARD, read through the documentation. Will fix this up all over.

[AliSoftware]

Thanks for the PR, looks very promising!

Ok for me once my remarks have all been addressed.

[AliSoftware]

The ruby standard name for this method is to_hash, not to_h

[justinseanmartin]

Seems to be differing information. From what I've read, appears that to_hash is specifically if the object acts like a hash and can be converted with no loss of fidelity. I don't think that is the case here. I don't feel strongly though, so LMK if I'm just misunderstood.

[AliSoftware]

Ah, actually you're right, didn't know about that. Let's keep to_h then.

[AliSoftware]

I definitely prefer that assign_variable.

BTW, talking about [] and []= it actually seem like a good addition (but still while keeping this assign_variable of course).

While assign_variable would take an EnvironmentVariable, Hash{Symbol=>String,Bool}, []= would take the variable name as key and expect the variable content as value (and would assume enabled=YES, no way to specify enabled with that syntax). And [] would take the variable name as key and return the EnvironmentVariable.
That could provide a nice syntactic sugar alternative. What do you think?

[justinseanmartin]

Works for me. Should [] operate on enabled variables only as well?

[AliSoftware]

I don't think so, since it would return an EnvironmentVariable anyway, I'd say let it access all variables (enabled or disabled). The user could still check the variable state once retrieved.

[justinseanmartin]

Added.

[AliSoftware]

Sorry not to have spotted that before, but could you fix the alignment/identation of all your YARD docs?

Convention is to align the text associated with @param so that it starts at the same column as the param type, like this

# Some description
#
# @param [Type] paramName
#        This parameter description starts as the same indentation level as the type
#        and continues with the same alignment if it wraps on multiple lines
#
def foo(paramName)
  ...
end

After that, I think I'm good 👍

[justinseanmartin]

All feedback addressed and squashed the commits.

[AliSoftware]

Still misaligned ;)

[justinseanmartin]

Fixed.

[AliSoftware]

LGTM now 👍 Will merge in a few once Travis is OK.

Nice work @justinseanmartin 🎉

[justinseanmartin]

Thanks for the prompt review feedback and dealing with a first time project contributor 😃

[AliSoftware]

Then even more awesome work for a first-time contributor then! 👍

[tirodkar]

I don't think this is pushed out to the latest release yet. This would be a great enhancement to have. Is there an ETA for the next release?

[segiddins]

@tirodkar there's no fixed release schedule, but this will ship with 1.0