Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Messages extension product types #390

Merged
merged 2 commits into from
Jun 27, 2016
Merged

Conversation

neonichu
Copy link
Member

Required for fixing CocoaPods/CocoaPods#5558

@segiddins
Copy link
Member

@benasher44 these changes compatible with your work?
If so, 👍 & 🚢 @neonichu

@benasher44
Copy link
Member

benasher44 commented Jun 27, 2016

Yep! Lg2m. @neonichu do messages extensions get embedded like watch 1 and app extensions? If so, I should update my CocoaPods PR to account for them once this is in.

@segiddins segiddins merged commit 41ee4dc into master Jun 27, 2016
@segiddins segiddins deleted the add-messages-extensions branch June 27, 2016 15:20
@neonichu
Copy link
Member Author

@benasher44 not sure, I have to check — but I assume they work similar to today extensions and the like.

@neonichu
Copy link
Member Author

@benasher44 Looks like it works as expected: Foo.app/PlugIns/MessagesExtension.appex, so your PR should account for them 👌

@benasher44
Copy link
Member

@neonichu okay thanks! I'm updating my PR, since it keeps a list of product types that need to be embedded. Does this apply to sticker packs as well (sorry should have asked about that too in the first place)?

@neonichu
Copy link
Member Author

As far as I understand it, the sticker packs don't contain any code, so nothing to do there for CP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants