#221 Fixed handling of xcdatamodeld packages in subfolders #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add test coverage and a CHANGELOG entry for this fix? Thanks! |
|
@segiddins done. I've tested the test case with and without my changes. With my changes it succeeded, without it failed. I'm not really experienced in Ruby so please let me know if there is anything I could improve. Thanks! |
endocrimes
reviewed
Oct 14, 2016
| @@ -12,6 +12,9 @@ | |||
| [Danielle Tomlinson](https://github.com/dantoml) | |||
| [#421](https://github.com/CocoaPods/Xcodeproj/pull/421) | |||
|
|
|||
| * Fixed handling of xcdatamodeld packages in subfolders. | |||
There was a problem hiding this comment.
Could you please add two spaces to the end of this? i.e * Fixed handling of xcdatamodeld packages in subfolders.
|
Finally the travis build finished (they had some incident that caused the delay) |
|
👍 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #221.
The PR #291 from @adamhrz unfortunately only works when the model is one folder deep in the hierarchy. As soon as it is located on a deeper level (e.g.
Source/CoreData/Model.xcdatamodeld), PR #291 leads to a crash.The underlying issue was that the
pathis relative to thegroupbut was handled as it would be absolute. I just joined the absolute/real path of thegroupwith thepathto create the correctreal_path.