[Fixtures] Updated CommonBuildSettings with Xcode 8.3

lib/xcodeproj/constants.rb

@@ -4,17 +4,17 @@ module Xcodeproj
   module Constants
     # @return [String] The last known iOS SDK (stable).
     #
-    LAST_KNOWN_IOS_SDK = '10.2'
+    LAST_KNOWN_IOS_SDK = '10.3'
 
     # @return [String] The last known OS X SDK (stable).
     #
     LAST_KNOWN_OSX_SDK = '10.12'
 
     # @return [String] The last known tvOS SDK (stable).
-    LAST_KNOWN_TVOS_SDK = '10.1'
+    LAST_KNOWN_TVOS_SDK = '10.2'
 
     # @return [String] The last known watchOS SDK (stable).
-    LAST_KNOWN_WATCHOS_SDK = '3.1'
+    LAST_KNOWN_WATCHOS_SDK = '3.2'
 
     # @return [String] The last known archive version to Xcodeproj.
     #
@@ -33,7 +33,7 @@ module Constants
 
     # @return [String] The last known object version to Xcodeproj.
     #
-    LAST_SWIFT_UPGRADE_CHECK = '0821'
+    LAST_SWIFT_UPGRADE_CHECK = '0830'
 
     # @return [String] The version of `.xcscheme` files supported by Xcodeproj
     #
@@ -273,6 +273,7 @@ module Constants
       [:ios, :application] => {
         'CODE_SIGN_IDENTITY[sdk=iphoneos*]' => 'iPhone Developer',
         'LD_RUNPATH_SEARCH_PATHS'           => ['$(inherited)', '@executable_path/Frameworks'],
+        'TARGETED_DEVICE_FAMILY'            => '1,2',
       }.freeze,
       [:osx, :application] => {
         'COMBINE_HIDPI_IMAGES'              => 'YES',
@@ -337,6 +338,7 @@ module Constants
         'GCC_WARN_UNINITIALIZED_AUTOS'       => 'YES',
         'GCC_WARN_UNUSED_FUNCTION'           => 'YES',
         'GCC_WARN_UNUSED_VARIABLE'           => 'YES',
+        'CLANG_ANALYZER_NUMBER_OBJECT_CONVERSION' => 'YES',
       },
       :release => {
         'COPY_PHASE_STRIP'                   => 'YES',

spec/fixtures/CommonBuildSettings/Project/Objc_iOS_Native/Assets.xcassets/AppIcon.appiconset/Contents.json

@@ -1,5 +1,15 @@
 {
   "images" : [
+    {
+      "idiom" : "iphone",
+      "size" : "20x20",
+      "scale" : "2x"
+    },
+    {
+      "idiom" : "iphone",
+      "size" : "20x20",
+      "scale" : "3x"
+    },
     {
       "idiom" : "iphone",
       "size" : "29x29",
@@ -29,6 +39,51 @@
       "idiom" : "iphone",
       "size" : "60x60",
       "scale" : "3x"
+    },
+    {
+      "idiom" : "ipad",
+      "size" : "20x20",
+      "scale" : "1x"
+    },
+    {
+      "idiom" : "ipad",
+      "size" : "20x20",
+      "scale" : "2x"
+    },
+    {
+      "idiom" : "ipad",
+      "size" : "29x29",
+      "scale" : "1x"
+    },
+    {
+      "idiom" : "ipad",
+      "size" : "29x29",
+      "scale" : "2x"
+    },
+    {
+      "idiom" : "ipad",
+      "size" : "40x40",
+      "scale" : "1x"
+    },
+    {
+      "idiom" : "ipad",
+      "size" : "40x40",
+      "scale" : "2x"
+    },
+    {
+      "idiom" : "ipad",
+      "size" : "76x76",
+      "scale" : "1x"
+    },
+    {
+      "idiom" : "ipad",
+      "size" : "76x76",
+      "scale" : "2x"
+    },
+    {
+      "idiom" : "ipad",
+      "size" : "83.5x83.5",
+      "scale" : "2x"
     }
   ],
   "info" : {

spec/fixtures/CommonBuildSettings/Project/Objc_iOS_Native/Info.plist

@@ -44,5 +44,12 @@
 		<string>UIInterfaceOrientationLandscapeLeft</string>
 		<string>UIInterfaceOrientationLandscapeRight</string>
 	</array>
+	<key>UISupportedInterfaceOrientations~ipad</key>
+	<array>
+		<string>UIInterfaceOrientationPortrait</string>
+		<string>UIInterfaceOrientationPortraitUpsideDown</string>
+		<string>UIInterfaceOrientationLandscapeLeft</string>
+		<string>UIInterfaceOrientationLandscapeRight</string>
+	</array>
 </dict>
 </plist>

spec/fixtures/CommonBuildSettings/Project/Objc_watchOS_Native Extension/InterfaceController.m

@@ -1,7 +1,7 @@
 #import "InterfaceController.h"
 
 
-@interface InterfaceController()
+@interface InterfaceController ()
 
 @end
 

spec/fixtures/CommonBuildSettings/Project/Objc_watchOS_Native Extension/NotificationController.m

@@ -1,7 +1,7 @@
 #import "NotificationController.h"
 
 
-@interface NotificationController()
+@interface NotificationController ()
 
 @end
 

spec/fixtures/CommonBuildSettings/Project/Swift_iOS_Native/AppDelegate.swift

@@ -8,7 +8,7 @@ class AppDelegate: UIResponder, UIApplicationDelegate, UISplitViewControllerDele
 
     func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplicationLaunchOptionsKey: Any]?) -> Bool {
         // Override point for customization after application launch.
-        let splitViewController = self.window!.rootViewController as! UISplitViewController
+        let splitViewController = window!.rootViewController as! UISplitViewController
         let navigationController = splitViewController.viewControllers[splitViewController.viewControllers.count-1] as! UINavigationController
         navigationController.topViewController!.navigationItem.leftBarButtonItem = splitViewController.displayModeButtonItem
         splitViewController.delegate = self

spec/fixtures/CommonBuildSettings/Project/Swift_iOS_Native/Assets.xcassets/AppIcon.appiconset/Contents.json

@@ -29,6 +29,36 @@
       "idiom" : "iphone",
       "size" : "60x60",
       "scale" : "3x"
+    },
+    {
+      "idiom" : "ipad",
+      "size" : "29x29",
+      "scale" : "1x"
+    },
+    {
+      "idiom" : "ipad",
+      "size" : "29x29",
+      "scale" : "2x"
+    },
+    {
+      "idiom" : "ipad",
+      "size" : "40x40",
+      "scale" : "1x"
+    },
+    {
+      "idiom" : "ipad",
+      "size" : "40x40",
+      "scale" : "2x"
+    },
+    {
+      "idiom" : "ipad",
+      "size" : "76x76",
+      "scale" : "1x"
+    },
+    {
+      "idiom" : "ipad",
+      "size" : "76x76",
+      "scale" : "2x"
     }
   ],
   "info" : {

spec/fixtures/CommonBuildSettings/Project/Swift_iOS_Native/DetailViewController.swift

@@ -7,8 +7,8 @@ class DetailViewController: UIViewController {
 
     func configureView() {
         // Update the user interface for the detail item.
-        if let detail = self.detailItem {
-            if let label = self.detailDescriptionLabel {
+        if let detail = detailItem {
+            if let label = detailDescriptionLabel {
                 label.text = detail.description
             }
         }
@@ -17,7 +17,7 @@ class DetailViewController: UIViewController {
     override func viewDidLoad() {
         super.viewDidLoad()
         // Do any additional setup after loading the view, typically from a nib.
-        self.configureView()
+        configureView()
     }
 
     override func didReceiveMemoryWarning() {
@@ -28,7 +28,7 @@ class DetailViewController: UIViewController {
     var detailItem: NSDate? {
         didSet {
             // Update the view.
-            self.configureView()
+            configureView()
         }
     }
 

spec/fixtures/CommonBuildSettings/Project/Swift_iOS_Native/Info.plist

@@ -44,5 +44,12 @@
 		<string>UIInterfaceOrientationLandscapeLeft</string>
 		<string>UIInterfaceOrientationLandscapeRight</string>
 	</array>
+	<key>UISupportedInterfaceOrientations~ipad</key>
+	<array>
+		<string>UIInterfaceOrientationPortrait</string>
+		<string>UIInterfaceOrientationPortraitUpsideDown</string>
+		<string>UIInterfaceOrientationLandscapeLeft</string>
+		<string>UIInterfaceOrientationLandscapeRight</string>
+	</array>
 </dict>
 </plist>

spec/fixtures/CommonBuildSettings/Project/Swift_iOS_Native/MasterViewController.swift

@@ -9,18 +9,18 @@ class MasterViewController: UITableViewController {
     override func viewDidLoad() {
         super.viewDidLoad()
         // Do any additional setup after loading the view, typically from a nib.
-        self.navigationItem.leftBarButtonItem = self.editButtonItem
+        navigationItem.leftBarButtonItem = editButtonItem
 
         let addButton = UIBarButtonItem(barButtonSystemItem: .add, target: self, action: #selector(insertNewObject(_:)))
-        self.navigationItem.rightBarButtonItem = addButton
-        if let split = self.splitViewController {
+        navigationItem.rightBarButtonItem = addButton
+        if let split = splitViewController {
             let controllers = split.viewControllers
-            self.detailViewController = (controllers[controllers.count-1] as! UINavigationController).topViewController as? DetailViewController
+            detailViewController = (controllers[controllers.count-1] as! UINavigationController).topViewController as? DetailViewController
         }
     }
 
     override func viewWillAppear(_ animated: Bool) {
-        self.clearsSelectionOnViewWillAppear = self.splitViewController!.isCollapsed
+        clearsSelectionOnViewWillAppear = splitViewController!.isCollapsed
         super.viewWillAppear(animated)
     }
 
@@ -32,18 +32,18 @@ class MasterViewController: UITableViewController {
     func insertNewObject(_ sender: Any) {
         objects.insert(NSDate(), at: 0)
         let indexPath = IndexPath(row: 0, section: 0)
-        self.tableView.insertRows(at: [indexPath], with: .automatic)
+        tableView.insertRows(at: [indexPath], with: .automatic)
     }
 
     // MARK: - Segues
 
     override func prepare(for segue: UIStoryboardSegue, sender: Any?) {
         if segue.identifier == "showDetail" {
-            if let indexPath = self.tableView.indexPathForSelectedRow {
+            if let indexPath = tableView.indexPathForSelectedRow {
                 let object = objects[indexPath.row] as! NSDate
                 let controller = (segue.destination as! UINavigationController).topViewController as! DetailViewController
                 controller.detailItem = object
-                controller.navigationItem.leftBarButtonItem = self.splitViewController?.displayModeButtonItem
+                controller.navigationItem.leftBarButtonItem = splitViewController?.displayModeButtonItem
                 controller.navigationItem.leftItemsSupplementBackButton = true
             }
         }

spec/fixtures/CommonBuildSettings/configs/OSX_Bundle/OSX_Bundle_base.xcconfig

@@ -1,8 +1,6 @@
+CLANG_ANALYZER_NUMBER_OBJECT_CONVERSION = YES_AGGRESSIVE
 CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR
-CLANG_WARN_DOCUMENTATION_COMMENTS = YES
-CLANG_WARN_INFINITE_RECURSION = YES
 CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR
-CLANG_WARN_SUSPICIOUS_MOVE = YES
 CODE_SIGN_IDENTITY = -
 COMBINE_HIDPI_IMAGES = YES
 ENABLE_STRICT_OBJC_MSGSEND = YES

spec/fixtures/CommonBuildSettings/configs/Objc_OSX_DynamicLibrary/Objc_OSX_DynamicLibrary_base.xcconfig

@@ -1,8 +1,6 @@
+CLANG_ANALYZER_NUMBER_OBJECT_CONVERSION = YES_AGGRESSIVE
 CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR
-CLANG_WARN_DOCUMENTATION_COMMENTS = YES
-CLANG_WARN_INFINITE_RECURSION = YES
 CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR
-CLANG_WARN_SUSPICIOUS_MOVE = YES
 CODE_SIGN_IDENTITY = -
 DYLIB_COMPATIBILITY_VERSION = 1
 DYLIB_CURRENT_VERSION = 1

spec/fixtures/CommonBuildSettings/configs/Objc_OSX_Framework/Objc_OSX_Framework_base.xcconfig

@@ -1,8 +1,6 @@
+CLANG_ANALYZER_NUMBER_OBJECT_CONVERSION = YES_AGGRESSIVE
 CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR
-CLANG_WARN_DOCUMENTATION_COMMENTS = YES
-CLANG_WARN_INFINITE_RECURSION = YES
 CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR
-CLANG_WARN_SUSPICIOUS_MOVE = YES
 CODE_SIGN_IDENTITY = -
 COMBINE_HIDPI_IMAGES = YES
 CURRENT_PROJECT_VERSION = 1

spec/fixtures/CommonBuildSettings/configs/Objc_OSX_Native/Objc_OSX_Native_base.xcconfig

@@ -1,9 +1,7 @@
 ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon
+CLANG_ANALYZER_NUMBER_OBJECT_CONVERSION = YES_AGGRESSIVE
 CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR
-CLANG_WARN_DOCUMENTATION_COMMENTS = YES
-CLANG_WARN_INFINITE_RECURSION = YES
 CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR
-CLANG_WARN_SUSPICIOUS_MOVE = YES
 CODE_SIGN_IDENTITY = -
 COMBINE_HIDPI_IMAGES = YES
 ENABLE_STRICT_OBJC_MSGSEND = YES

spec/fixtures/CommonBuildSettings/configs/Objc_OSX_StaticLibrary/Objc_OSX_StaticLibrary_base.xcconfig

@@ -1,8 +1,6 @@
+CLANG_ANALYZER_NUMBER_OBJECT_CONVERSION = YES_AGGRESSIVE
 CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR
-CLANG_WARN_DOCUMENTATION_COMMENTS = YES
-CLANG_WARN_INFINITE_RECURSION = YES
 CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR
-CLANG_WARN_SUSPICIOUS_MOVE = YES
 CODE_SIGN_IDENTITY = -
 ENABLE_STRICT_OBJC_MSGSEND = YES
 EXECUTABLE_PREFIX = lib

spec/fixtures/CommonBuildSettings/configs/Objc_iOS_Framework/Objc_iOS_Framework_base.xcconfig

@@ -1,8 +1,6 @@
+CLANG_ANALYZER_NUMBER_OBJECT_CONVERSION = YES_AGGRESSIVE
 CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR
-CLANG_WARN_DOCUMENTATION_COMMENTS = YES
-CLANG_WARN_INFINITE_RECURSION = YES
 CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR
-CLANG_WARN_SUSPICIOUS_MOVE = YES
 CODE_SIGN_IDENTITY =
 CODE_SIGN_IDENTITY[sdk=iphoneos*] = iPhone Developer
 CURRENT_PROJECT_VERSION = 1
@@ -16,7 +14,7 @@ GCC_WARN_ABOUT_RETURN_TYPE = YES_ERROR
 GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE
 INFOPLIST_FILE = Objc_iOS_Framework/Info.plist
 INSTALL_PATH = $(LOCAL_LIBRARY_DIR)/Frameworks
-IPHONEOS_DEPLOYMENT_TARGET = 10.2
+IPHONEOS_DEPLOYMENT_TARGET = 10.3
 LD_RUNPATH_SEARCH_PATHS = $(inherited) @executable_path/Frameworks @loader_path/Frameworks
 PRODUCT_BUNDLE_IDENTIFIER = org.cocoapods.Objc-iOS-Framework
 PRODUCT_NAME = $(TARGET_NAME)

spec/fixtures/CommonBuildSettings/configs/Objc_iOS_Native/Objc_iOS_Native_base.xcconfig

@@ -1,17 +1,16 @@
 ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon
+CLANG_ANALYZER_NUMBER_OBJECT_CONVERSION = YES_AGGRESSIVE
 CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR
-CLANG_WARN_DOCUMENTATION_COMMENTS = YES
-CLANG_WARN_INFINITE_RECURSION = YES
 CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR
-CLANG_WARN_SUSPICIOUS_MOVE = YES
 CODE_SIGN_IDENTITY[sdk=iphoneos*] = iPhone Developer
 ENABLE_STRICT_OBJC_MSGSEND = YES
 GCC_NO_COMMON_BLOCKS = YES
 GCC_WARN_ABOUT_RETURN_TYPE = YES_ERROR
 GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE
 INFOPLIST_FILE = Objc_iOS_Native/Info.plist
-IPHONEOS_DEPLOYMENT_TARGET = 10.2
+IPHONEOS_DEPLOYMENT_TARGET = 10.3
 LD_RUNPATH_SEARCH_PATHS = $(inherited) @executable_path/Frameworks
 PRODUCT_BUNDLE_IDENTIFIER = org.cocoapods.Objc-iOS-Native
 PRODUCT_NAME = $(TARGET_NAME)
 SDKROOT = iphoneos
+TARGETED_DEVICE_FAMILY = 1,2

spec/fixtures/CommonBuildSettings/configs/Objc_iOS_StaticLibrary/Objc_iOS_StaticLibrary_base.xcconfig

@@ -1,14 +1,12 @@
+CLANG_ANALYZER_NUMBER_OBJECT_CONVERSION = YES_AGGRESSIVE
 CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR
-CLANG_WARN_DOCUMENTATION_COMMENTS = YES
-CLANG_WARN_INFINITE_RECURSION = YES
 CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR
-CLANG_WARN_SUSPICIOUS_MOVE = YES
 CODE_SIGN_IDENTITY[sdk=iphoneos*] = iPhone Developer
 ENABLE_STRICT_OBJC_MSGSEND = YES
 GCC_NO_COMMON_BLOCKS = YES
 GCC_WARN_ABOUT_RETURN_TYPE = YES_ERROR
 GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE
-IPHONEOS_DEPLOYMENT_TARGET = 10.2
+IPHONEOS_DEPLOYMENT_TARGET = 10.3
 OTHER_LDFLAGS = -ObjC
 PRODUCT_NAME = $(TARGET_NAME)
 SDKROOT = iphoneos