Xcode 10 support for input file list and output file list #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified the project in CocoaPods issue no longer has a warning, does not crash if there are input or output file lists present and also verified that we can set these values. |
|
I had a script to get the array settings, but that shouldn’t block this PR. We’ll need to add a changelog entry and a test |
|
Will do! |
dnkoutso
force-pushed
the
xcode10_support
branch
from
052f7b8
to
d43c46f
Compare
|
Done. |
dnkoutso
force-pushed
the
xcode10_support
branch
from
d43c46f
to
c83bb56
Compare
segiddins
approved these changes
Jun 15, 2018
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes CocoaPods/CocoaPods#7835
@segiddins how was
build_settings_array_settings_by_object_version.rbgenerated for version 50? Was it manual? Looking to see if we can generate it for version 51.