Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only require 'digest' once instead of on every call of uuid_for_path #580

Merged
merged 1 commit into from
Jun 19, 2018
Merged

Only require 'digest' once instead of on every call of uuid_for_path #580

merged 1 commit into from
Jun 19, 2018

Conversation

amorde
Copy link
Member

@amorde amorde commented Jun 19, 2018

Although Ruby does cache the results of require, this still appears to be accounting for a significant portion of pod install. It's called over 10,000 times on a project I am testing.

This reduced the pod install time on a test project from ~12s to ~10s.

@dnkoutso
Copy link
Contributor

LGTM

@segiddins segiddins merged commit 5d9add3 into CocoaPods:master Jun 19, 2018
@amorde amorde deleted the require-once branch June 20, 2018 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants