Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use modern localization identifier 'en' for the development region #669

Merged
merged 1 commit into from
Apr 16, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@
* Normalize xcconfig path when generating includes.
[bclymer](https://github.com/bclymer)

* Use modern localization identifier 'en' for the development region.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change log entry was not rebased to latest master it now appears as if it was in 1.8.2 will fix.

[Steffen Matthischke](https://github.com/heeaad)

## 1.8.1 (2019-02-19)

##### Enhancements
Expand Down
2 changes: 1 addition & 1 deletion lib/xcodeproj/project/object/root_object.rb
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ class PBXProject < AbstractObject

# @return [String] the development region of the project.
#
attribute :development_region, String, 'English'
attribute :development_region, String, 'en'

# @return [String] whether the project has scanned for encodings.
#
Expand Down
2 changes: 1 addition & 1 deletion spec/project/object/root_object_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ module ProjectSpecs
end

it 'returns the development region' do
@root_object.development_region.should == 'English'
@root_object.development_region.should == 'en'
end

it 'returns whether has scanned for encodings' do
Expand Down