Fix incorrect formatting of build settings with modifiers

[revolter]

Fixes #666 😈

[revolter]

Should I add a test case for this?

[dnkoutso]

Yes please!

[revolter]

Done!

[revolter]

What's the issue?

[dnkoutso]

Something is wrong with build on "xit or fit left in tests (spec/project/object/build_configuration_spec.rb)"

LGTM otherwise.

[revolter]

I fixed it, but it's weird that it was already in master but the last commits on master are green.

[dnkoutso]

Hm maybe danger was updated. If the test was disabled we can even delete it as it probably has been disable for a while.

[revolter]

I think that it was only a mistake, and we actually do need those tests. They were added in 7b5c780.

[revolter]

Yeah, it looks like the tests are indeed wrong.

[revolter]

I think that the bug that the tests are trying to prevent still exists and will need to be fixed in the future, but that doesn't have anything to do with my changes, so if all is good, this should be merged.

[revolter]

@dnkoutso, Could you please merge this? 😃

[dnkoutso]

/?hmmm I'd like to fix the build first. Maybe in a separate PR

[revolter]

Will you or @segiddins take care of it? And, when will be the next release? I'm worried that it will take a lot of time until I get this change, as it has to be released in a new Xcodeproj version, then create a PR in CocoaPods, then get it merged, then wait for a new CocoaPods release 😟

[dnkoutso]

You can use Bundler https://bundler.io/v1.12/git.html to pin to your fork or branch if this change is blocking you and you don't want to wait for a release, which is understandable.

[revolter]

Wouldn't be better if this was merged now? As you're obviously very busy and you won't ever fix those old failing checks unrelated to this change.

Also, I think that @segiddins is the most able to solve it.

[barakwei]

Can this be merged? Looks like tests are passing, and there's some unrelated issue.

[segiddins]

Danger has failed this build. 
Found 1 error.

[barakwei]

Can we please move the forward somehow? it seems like a CI failure to me and not something in the PR. Can we run CI again?

[segiddins]

Re-kicked CI

[revolter]

Ok, so in other PRs, there's:

Danger does not have write access to the PR to set a PR status.

Sorry, but, this is bullshit! So my PR was not merged for 3 months because of an error 100% not caused by me, that is not catched in other PRs because of Danger not running at all!

Again, error source:

https://github.com/CocoaPods/Xcodeproj/blame/2bc4222ff4664386363cda25c56d2b54c20d565e/spec/project/object/build_configuration_spec.rb#L118-L122

[revolter]

So knowing that it will take a looot of time until this gets into CocoaPods, please merge it as soon as possible, and try to make a new release containing this, again, as soon as possible.

[revolter]

Also, is it ok that DANGER_GITHUB_API_TOKEN can be found in https://api.travis-ci.org/v3/job/607538923/log.txt?

[segiddins]

cc @orta on the danger issue

[segiddins]

@revolter

Sorry, but, this is bullshit

I'm sorry, but this attitude is not acceptable. CocoaPods is maintained by people in their spare time, and complaining rudely about failing builds or slow release cycles will not make anything happen faster.

[revolter]

@segiddins, You're right, I'm sorry for using that word, but I consider that I did everything I could, and the only thing I needed for you was to merge it, nothing more, no extra work.

complaining rudely about failing builds or slow release cycles will not make anything happen faster.

I did not do this. I complained about ignoring my "research" related to the issue, that concluded in the fact that it was 100% not introduced by me in this PR.
And I surely didn't complain about slow release cycles, I completely understand it, it was provided as an extra reason of merging my work. I waited 3 months, so I can wait more.
Also, not only did I not complain, I also spent time to look into it, git blame it, try to fix them myself, even if completely unrelated, and I was met with rejections without a reason (1, 2) or simply ignored (1, 2).

So, again, I know a little about maintaining open source projects, I completely understand the huge effort and time spent by the maintainers, and I have no problem whatsoever to do everything I can to make your job easier.

[revolter]

Also, it's weird that there is a Danger check with is green, but the CI check fails because of Danger.

[orta]

The message is here: #706 (comment)

if it's fixed upstream, maybe rebase? that error just exists in the current code from the sounds of things

[revolter]

@orta, Yes, xit is the cause. The problem is that other (some) PRs don't trigger this, and this is logged:

Danger does not have write access to the PR to set a PR status.

[orta]

The dangerfile only looks at modified files for the xit/fit checks, and this PR includes those changes - and don't worry about the status update message, that's because the CI version doesn't have write access to the repo, which we want.

[revolter]

Got it, thanks a lot!

[revolter]

@orta, What about #706 (comment)?

[orta]

Yep, totally fine, this is set up right - https://danger.systems/guides/faq.html#why-am-i-seeing-quot-set-status-failed-quot-on-my-github-oss-project

[revolter]

As #727 was merged, I rebased this branch and it builds successfully, so this is now ready for merge.

[revolter]

To use this fix before it gets officially released, add an explicit xcodeproj gem dependency in your Gemfile like:

# frozen_string_literal: true

source 'https://rubygems.org' do
    gem 'cocoapods'
    gem 'xcodeproj', git: 'https://github.com/CocoaPods/Xcodeproj.git', ref: '70d114e'
end

[revolter]

To use this fix after it was officially released, simply run bundle update xcodeproj.