Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't raise an exception on newer Xcode than latest known #953

Merged
merged 4 commits into from
Aug 2, 2024
Merged

Don't raise an exception on newer Xcode than latest known #953

merged 4 commits into from
Aug 2, 2024

Conversation

Kaspik
Copy link
Contributor

@Kaspik Kaspik commented Aug 2, 2024

  • remove exception on newer Xcode version and log only warning to inform user they are using newer xcode than the latest supported by xcodeproj - if things don't work, it will fail automatically on the right place - but chance is newer Xcode simply works so there is no reason why users should be blocked by outdated xcodeproj

Fixes issues like #933 where fix is merged in but still not released and users are blocked for months.

Copy link

@martinpucik martinpucik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for issue we're facing 👍

@orta
Copy link
Member

orta commented Aug 2, 2024

Can you switch this around to a warning please (and make it a bit more human friendly), and I'll get this merged - I think it's the right thing to do at this point

@orta
Copy link
Member

orta commented Aug 2, 2024

There's also the one above, which might need it too?

@Kaspik
Copy link
Contributor Author

Kaspik commented Aug 2, 2024

Happy to do so! (once I find out how I throw warning 😃 )

@Kaspik
Copy link
Contributor Author

Kaspik commented Aug 2, 2024

Update to puts with a WARN: prefix

@orta
Copy link
Member

orta commented Aug 2, 2024

We use UI.warn - https://github.com/CocoaPods/Xcodeproj/blob/fe55cf57badef2ca27fb9d4f801d9b834de1f871/lib/xcodeproj/project/object.rb#L321C13-L321C22 which should make it consistent with other stuff (I'd offer a suggestion but there could be lint issues from it )

@Kaspik
Copy link
Contributor Author

Kaspik commented Aug 2, 2024

Thanks, done! ✅

@Kaspik
Copy link
Contributor Author

Kaspik commented Aug 2, 2024

@orta Once this gets out, any chance we could do a release? Not only for this, but the CVE-Vulnerability fix should also get out finally. :)

@orta
Copy link
Member

orta commented Aug 2, 2024

That is more complex and out of my hands to commit to I'm afraid, but I'd like to see it happen too

@Kaspik
Copy link
Contributor Author

Kaspik commented Aug 2, 2024

Understand, let's merge this and we will see how others feel about a new release.

@orta orta merged commit bf23c4c into CocoaPods:master Aug 2, 2024
4 checks passed
@Kaspik Kaspik deleted the patch-1 branch August 2, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants